Skip to content

fix(ske): Store ids immediately after provisioning#1289

Merged
Fyusel merged 2 commits intomainfrom
ske-store-ids-after-provisioning
Mar 12, 2026
Merged

fix(ske): Store ids immediately after provisioning#1289
Fyusel merged 2 commits intomainfrom
ske-store-ids-after-provisioning

Conversation

@Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Mar 11, 2026

STACKITTPR-397

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

STACKITTPR-397

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel Fyusel force-pushed the ske-store-ids-after-provisioning branch from 8a11a4c to c463fb0 Compare March 11, 2026 12:20
@Fyusel Fyusel requested a review from a team as a code owner March 11, 2026 12:20
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 49.28% (+0.11%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig 25.42% (+0.42%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 51.50% (+0.12%) 864 (-2) 445 419 (-2) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig/resource.go 25.42% (+0.42%) 177 (-3) 45 132 (-3) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_test.go

@Fyusel Fyusel merged commit f4be46e into main Mar 12, 2026
3 checks passed
@Fyusel Fyusel deleted the ske-store-ids-after-provisioning branch March 12, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants